add version defines so that UniGLTF, UnityGLTF and glTFast can co-exist #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
added
editor
Package
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm the maintainer of https://github.com/khronosgroup/unitygltf. We've got some reports of incompatibility when both UnityGLTF and UniGLTF are in the same project, leading to users believing that either project is broken while they're not.
This PR builds on
and makes UniGLTF play nice with UnityGLTF and glTFast in the same project.
With this PR in place, all three can co-exist and will all be available as importer overrides.
Before this PR, users had to manually add
UNIGLTF_DISABLE_DEFAULT_GLB_IMPORTERandUNIGLTF_DISABLE_DEFAULT_GLTF_IMPORTERto their scripting settings which was confusing – with this PR it's automatic. And if neither glTFast nor UnityGLTF are present, there is no change in behaviour either.